Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple partial registrations to resolver #156672

Merged
merged 9 commits into from
Aug 2, 2022

Conversation

lramos15
Copy link
Member

@lramos15 lramos15 commented Jul 29, 2022

This PR fixes #153963

Allows for registering individual factories to the resolver rather than whole objects in the same place. The resolver will then merge these together when querying for editors to make the right editor choice.

@lramos15 lramos15 self-assigned this Jul 29, 2022
@lramos15 lramos15 requested a review from bpasero July 29, 2022 14:55
@lramos15 lramos15 added this to the August 2022 milestone Jul 29, 2022
@lramos15 lramos15 removed the request for review from bpasero July 29, 2022 14:57
@lramos15 lramos15 marked this pull request as draft July 29, 2022 14:57
@lramos15 lramos15 requested a review from bpasero August 2, 2022 15:15
@lramos15 lramos15 marked this pull request as ready for review August 2, 2022 15:22
bpasero
bpasero previously approved these changes Aug 2, 2022
@lramos15 lramos15 merged commit cf42408 into main Aug 2, 2022
@lramos15 lramos15 deleted the lramos15/partialRegistrationResolver branch August 2, 2022 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants